summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <junkio@cox.net>2005-05-30 20:53:45 (GMT)
committerLinus Torvalds <torvalds@ppc970.osdl.org>2005-05-31 01:10:46 (GMT)
commit2036d841020b7500eca7d568bd0c353b4fe73408 (patch)
treebb1208cb084fcbe33ab225db7dec133a5eb19d30
parent866b973b5d418622cbe28fea85169379dcb30f9d (diff)
downloadgit-2036d841020b7500eca7d568bd0c353b4fe73408.zip
git-2036d841020b7500eca7d568bd0c353b4fe73408.tar.gz
git-2036d841020b7500eca7d568bd0c353b4fe73408.tar.bz2
[PATCH] Buglets fix in the new two scripts
Should be obvious... - Use $VISUAL, $EDITOR, in this order if set, and fall back on vi. - Status R, C, D, N usually are followed by number, so adjust case arms to that pattern. Signed-off-by: Junio C Hamano <junkio@cox.net> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
-rwxr-xr-xgit-commit-script4
-rwxr-xr-xgit-status-script14
2 files changed, 8 insertions, 10 deletions
diff --git a/git-commit-script b/git-commit-script
index f8d568c..42ee399 100755
--- a/git-commit-script
+++ b/git-commit-script
@@ -5,9 +5,7 @@ then
cat .editmsg
exit 1
fi
-ED=${VISUAL:$EDITOR}
-ED=${ED:vi}
-$ED .editmsg
+${VISUAL:-${EDITOR:-vi}} .editmsg
grep -v '^#' < .editmsg | git-stripspace > .cmitmsg
[ -s .cmitmsg ] || exit 1
tree=$(git-write-tree) || exit 1
diff --git a/git-status-script b/git-status-script
index 72a93f7..f91bb55 100755
--- a/git-status-script
+++ b/git-status-script
@@ -13,13 +13,13 @@ report () {
trailer="#
"
case "$status" in
- M) echo "# modified: $name";;
- D) echo "# deleted: $name";;
- T) echo "# typechange: $name";;
- C) echo "# copied: $name -> $newname";;
- R) echo "# renamed: $name -> $newname";;
- N) echo "# new file: $name";;
- U) echo "# unmerged: $name";;
+ M ) echo "# modified: $name";;
+ D*) echo "# deleted: $name";;
+ T ) echo "# typechange: $name";;
+ C*) echo "# copied: $name -> $newname";;
+ R*) echo "# renamed: $name -> $newname";;
+ N*) echo "# new file: $name";;
+ U ) echo "# unmerged: $name";;
esac
done
echo -n "$trailer"