summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorFilippo Negroni <fnegroni@flexerasoftware.com>2010-02-25 10:01:31 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-02-25 20:08:22 (GMT)
commit1f80c2afb0d826567a9a5a1c3ce76c28883e0e96 (patch)
tree9a5a5658f26fbeae32ed47b6c8a94fe3038c0805
parent0606c36a73449e76d8f6133253c1eff291ee8c97 (diff)
downloadgit-1f80c2afb0d826567a9a5a1c3ce76c28883e0e96.zip
git-1f80c2afb0d826567a9a5a1c3ce76c28883e0e96.tar.gz
git-1f80c2afb0d826567a9a5a1c3ce76c28883e0e96.tar.bz2
Fix gitmkdtemp: correct test for mktemp() return value
In gitmkdtemp, the return value of mktemp is not tested correctly. mktemp() always returns its 'template' argument, even upon failure. An error is signalled by making the template an empty string. Signed-off-by: Filippo Negroni <fnegroni@flexerasoftware.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--compat/mkdtemp.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/compat/mkdtemp.c b/compat/mkdtemp.c
index 34d4b49..1136119 100644
--- a/compat/mkdtemp.c
+++ b/compat/mkdtemp.c
@@ -2,7 +2,7 @@
char *gitmkdtemp(char *template)
{
- if (!mktemp(template) || mkdir(template, 0700))
+ if (!*mktemp(template) || mkdir(template, 0700))
return NULL;
return template;
}