diff options
authorDerrick Stolee <>2022-04-13 15:32:31 (GMT)
committerJunio C Hamano <>2022-04-13 19:42:51 (GMT)
commit0f85c4a30b072a26d74af8bbf63cc8f6a5dfc1b8 (patch)
parentbb50ec3cc300eeff3aba7a2bea145aabdb477d31 (diff)
setup: opt-out of check with*
With the addition of the in 8959555ce (setup_git_directory(): add an owner check for the top-level directory, 2022-03-02) released in v2.35.2, we are receiving feedback from a variety of users about the feature. Some users have a very large list of shared repositories and find it cumbersome to add this config for every one of them. In a more difficult case, certain workflows involve running Git commands within containers. The container boundary prevents any global or system config from communicating `` values from the host into the container. Further, the container almost always runs as a different user than the owner of the directory in the host. To simplify the reactions necessary for these users, extend the definition of the config value to include a possible '*' value. This value implies that all directories are safe, providing a single setting to opt-out of this protection. Note that an empty assignment of clears all previous values, and this is already the case with the "if (!value || !*value)" condition. Signed-off-by: Derrick Stolee <> Signed-off-by: Junio C Hamano <>
3 files changed, 21 insertions, 2 deletions
diff --git a/Documentation/config/safe.txt b/Documentation/config/safe.txt
index 63597b2..6d764fe 100644
--- a/Documentation/config/safe.txt
+++ b/Documentation/config/safe.txt
@@ -19,3 +19,10 @@ line option `-c<path>`.
The value of this setting is interpolated, i.e. `~/<path>` expands to a
path relative to the home directory and `%(prefix)/<path>` expands to a
path relative to Git's (runtime) prefix.
+To completely opt-out of this security check, set `` to the
+string `*`. This will allow all repositories to be treated as if their
+directory was listed in the `` list. If `*`
+is set in system config and you want to re-enable this protection, then
+initialize your list with an empty value before listing the repositories
+that you deem safe.
diff --git a/setup.c b/setup.c
index 4b9f073..aad9ace 100644
--- a/setup.c
+++ b/setup.c
@@ -1037,9 +1037,11 @@ static int safe_directory_cb(const char *key, const char *value, void *d)
if (strcmp(key, ""))
return 0;
- if (!value || !*value)
+ if (!value || !*value) {
data->is_safe = 0;
- else {
+ } else if (!strcmp(value, "*")) {
+ data->is_safe = 1;
+ } else {
const char *interpolated = NULL;
if (!git_config_pathname(&interpolated, key, value) &&
diff --git a/t/ b/t/
index 6f33c0d..239d93f 100755
--- a/t/
+++ b/t/
@@ -36,4 +36,14 @@ test_expect_success ' matches, but is reset' '
+test_expect_success '*' '
+ git config --global --add "*" &&
+ git status
+test_expect_success '*, but is reset' '
+ git config --global --add "" &&
+ expect_rejected_dir