summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <junkio@cox.net>2007-03-08 10:12:06 (GMT)
committerJunio C Hamano <junkio@cox.net>2007-03-14 08:33:41 (GMT)
commit0497c620cae0531815afc4ada783b488eab3f447 (patch)
treede01b8eed6e9994651491c7452445a605255585e
parent86952cdabdcc550a20794794db539c41877d17fc (diff)
downloadgit-0497c620cae0531815afc4ada783b488eab3f447.zip
git-0497c620cae0531815afc4ada783b488eab3f447.tar.gz
git-0497c620cae0531815afc4ada783b488eab3f447.tar.bz2
shortlog: prompt when reading from terminal by mistake
I was trying to see who have been active recently to find GSoC mentor candidates by running: $ git shortlog -s -n --since=4.months | head -n 20 After waiting for about 20 seconds, I started getting worried, thinking that the recent revision traversal updates might have had an unintended side effect. Not so. "git shortlog" acts as a filter when no revs are given, unlike "git log" which defaults to HEAD. It was reading from its standard input. Signed-off-by: Junio C Hamano <junkio@cox.net>
-rw-r--r--builtin-shortlog.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/builtin-shortlog.c b/builtin-shortlog.c
index 2d7726e..29343ae 100644
--- a/builtin-shortlog.c
+++ b/builtin-shortlog.c
@@ -304,8 +304,11 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)
if (!access(".mailmap", R_OK))
read_mailmap(".mailmap");
- if (rev.pending.nr == 0)
+ if (rev.pending.nr == 0) {
+ if (isatty(0))
+ fprintf(stderr, "(reading log to summarize from standard input)\n");
read_from_stdin(&list);
+ }
else
get_from_rev(&rev, &list);