summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2022-07-21 01:02:15 (GMT)
committerJunio C Hamano <gitster@pobox.com>2022-07-21 04:46:21 (GMT)
commit1e11fab59c71d191970233cf8c2f573458ed952c (patch)
tree89de94679a164b09b726bbc8733973bcb501d0df
parent359da658ae32d9a7e5e93ac173fc221352b62917 (diff)
downloadgit-1e11fab59c71d191970233cf8c2f573458ed952c.zip
git-1e11fab59c71d191970233cf8c2f573458ed952c.tar.gz
git-1e11fab59c71d191970233cf8c2f573458ed952c.tar.bz2
builtin/remote.c: use the right kind of STRING_LIST_INIT
Since 4a4b4cda (builtin-remote: Make "remote -v" display push urls, 2009-06-13), the string_list that was initialized with 0 in its strdup_string member is immediately made to strdup its key strings by flipping the strdup_string member to true. When 183113a5 (string_list: Add STRING_LIST_INIT macro and make use of it., 2010-07-04) has introduced STRING_LIST_INIT macros, it mechanically replaced the initialization to STRING_LIST_INIT_NODUP. Instead, just use the other initialization macro to make it strdup the key from the beginning. Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin/remote.c3
1 files changed, 1 insertions, 2 deletions
diff --git a/builtin/remote.c b/builtin/remote.c
index 299c466..ac3ab44 100644
--- a/builtin/remote.c
+++ b/builtin/remote.c
@@ -1189,10 +1189,9 @@ static int get_one_entry(struct remote *remote, void *priv)
static int show_all(void)
{
- struct string_list list = STRING_LIST_INIT_NODUP;
+ struct string_list list = STRING_LIST_INIT_DUP;
int result;
- list.strdup_strings = 1;
result = for_each_remote(get_one_entry, &list);
if (!result) {