summaryrefslogtreecommitdiff
path: root/.tsan-suppressions
diff options
context:
space:
mode:
authorMartin Ågren <martin.agren@gmail.com>2017-08-21 17:43:48 (GMT)
committerJunio C Hamano <gitster@pobox.com>2017-08-23 17:38:56 (GMT)
commit6cdf8a7929688ea5702ab53f450d038e973e64e1 (patch)
tree6bc1c2972542be1c7ada97faefa345278b582c7e /.tsan-suppressions
parent65961d5a75e28aa04a90ee65106f71da177fd4b3 (diff)
downloadgit-6cdf8a7929688ea5702ab53f450d038e973e64e1.zip
git-6cdf8a7929688ea5702ab53f450d038e973e64e1.tar.gz
git-6cdf8a7929688ea5702ab53f450d038e973e64e1.tar.bz2
ThreadSanitizer: add suppressions
Add a file .tsan-suppressions and list two functions in it: want_color() and transfer_debug(). Both of these use the pattern static int foo = -1; if (foo < 0) foo = bar(); where bar always returns the same non-negative value. This can cause ThreadSanitizer to diagnose a race when foo is written from two threads. That is indeed a race, although it arguably doesn't matter in practice since it's always the same value that is written. Add NEEDSWORK-comments to the functions so that this problem is not forever swept way under the carpet. The suppressions-file is used by setting the environment variable TSAN_OPTIONS to, e.g., "suppressions=$(pwd)/.tsan-suppressions". Observe that relative paths such as ".tsan-suppressions" might not work. Signed-off-by: Martin Ågren <martin.agren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to '.tsan-suppressions')
-rw-r--r--.tsan-suppressions10
1 files changed, 10 insertions, 0 deletions
diff --git a/.tsan-suppressions b/.tsan-suppressions
new file mode 100644
index 0000000..8c85014
--- /dev/null
+++ b/.tsan-suppressions
@@ -0,0 +1,10 @@
+# Suppressions for ThreadSanitizer (tsan).
+#
+# This file is used by setting the environment variable TSAN_OPTIONS to, e.g.,
+# "suppressions=$(pwd)/.tsan-suppressions". Observe that relative paths such as
+# ".tsan-suppressions" might not work.
+
+# A static variable is written to racily, but we always write the same value, so
+# in practice it (hopefully!) doesn't matter.
+race:^want_color$
+race:^transfer_debug$