summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorEric Wong <normalperson@yhbt.net>2012-01-04 09:01:51 (GMT)
committerLars Hjemli <hjemli@gmail.com>2012-03-18 09:26:31 (GMT)
commit21418ec42a9a2de4c2c22eca7a1183b311914eca (patch)
tree76466eb627a017c57686530f0458699cb60d5684
parent6a575b8900734a4640427416885e73c83af70736 (diff)
downloadcgit-21418ec42a9a2de4c2c22eca7a1183b311914eca.zip
cgit-21418ec42a9a2de4c2c22eca7a1183b311914eca.tar.gz
cgit-21418ec42a9a2de4c2c22eca7a1183b311914eca.tar.bz2
segfault fix on some bogus requests
ctx.qry.head can be NULL in some cases due to bad requests by weird bots. I managed to reproduce with: PATH_INFO=/repo.git/shop.php QUERY_STRING=id= Signed-off-by: Eric Wong <normalperson@yhbt.net>
-rw-r--r--ui-shared.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/ui-shared.c b/ui-shared.c
index 3e9282f..d7d75bf 100644
--- a/ui-shared.c
+++ b/ui-shared.c
@@ -294,7 +294,7 @@ void cgit_log_link(const char *name, const char *title, const char *class,
char *delim;
delim = repolink(title, class, "log", head, path);
- if (rev && strcmp(rev, ctx.qry.head)) {
+ if (rev && ctx.qry.head && strcmp(rev, ctx.qry.head)) {
html(delim);
html("id=");
html_url_arg(rev);
@@ -338,7 +338,7 @@ void cgit_commit_link(char *name, const char *title, const char *class,
char *delim;
delim = repolink(title, class, "commit", head, path);
- if (rev && strcmp(rev, ctx.qry.head)) {
+ if (rev && ctx.qry.head && strcmp(rev, ctx.qry.head)) {
html(delim);
html("id=");
html_url_arg(rev);